Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of security-revoking srk keys #664

Closed
wants to merge 2 commits into from
Closed

Cleanup of security-revoking srk keys #664

wants to merge 2 commits into from

Conversation

kprosise
Copy link
Contributor

Applied style rules, cleaned up for clarity and readability.

QA Steps: ran linter, spellcheck, and checked rendered output.

This applies to FFTK-2795

Readiness

  • Merge (pending reviews)
  • Merge after date or event
  • Draft

Overview

Why merge this PR? What does it solve?

Checklist

Optional. Add a 'x' to steps taken.
You can fill this out after opening the PR. "Did I..."

  • Run spelling and grammar check, preferably with linter.
  • Avoid changing any header associated with a link/reference.
  • Step through instructions (or ask someone to do so).
  • Review for wordiness
  • Match tone and style of page/section.
  • Run make linkcheck.
  • View HTML in a browser to check rendering.
  • Use semantic newlines.
  • follow best practices for commits.
    • Descriptive title written in the imperative.
    • Include brief overview of QA steps taken.
    • Mention any related issues numbers.
    • End message with sign off/DCO line (-s, --signoff).
    • Sign commit with your gpg key (-S, --gpg-sign).
    • Squash commits if needed.
  • Request PR review by a technical writer and at least one peer.

Comments

Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.

@kprosise
Cleanup of security-revoking srk keys
16fac1e 
Applied style rules, cleaned up for clarity and readability.

QA Steps: ran linter, spellcheck, and checked rendered output.

This applies to FFTK-2795

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise requested review from angolini, vanmaegima and a team January 18, 2024 12:46
@doanac
Copy link
Member

doanac commented Jan 18, 2024

Docs for 16fac1e are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2567/docs/artifacts/html/index.html

@doanac
Copy link
Member

doanac commented Jan 23, 2024

Docs for 6deb1b0 are browsable at: https://ci.foundries.io/projects/fio-docs/builds/2573/docs/artifacts/html/index.html

@kprosise
Copy link
Contributor Author

Closing, will open a new PR to merge; easiest way to address merge conflict.

@kprosise kprosise closed this Jan 30, 2024
kprosise added a commit to kprosise/docs that referenced this pull request Jan 30, 2024
@kprosise
Cleanup of security-revoking srk keys
58a9fff 
Applied style rules, cleaned up for clarity and readability.

QA Steps: ran linter, spellcheck, and checked rendered output.

This commit is to replace the now closed/canceled PR foundriesio#664.

This applies to FFTK-2795

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise mentioned this pull request Jan 30, 2024
Merged
kprosise added a commit that referenced this pull request Jan 30, 2024
@kprosise
Cleanup of security-revoking srk keys
f45a1a2 
Applied style rules, cleaned up for clarity and readability.

QA Steps: ran linter, spellcheck, and checked rendered output.

This commit is to replace the now closed/canceled PR #664.

This applies to FFTK-2795

Signed-off-by: Katrina Prosise <[email protected]>
@kprosise kprosise deleted the cleanup-security-revoke-sb-keys branch March 12, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrCry0 MrCry0 MrCry0 approved these changes

@angolini angolini angolini approved these changes

@vanmaegima vanmaegima Awaiting requested review from vanmaegima

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kprosise @doanac @MrCry0 @angolini